Fixes copy code not working for modal due to no focus in Modal #22366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
sgiehl
approved these changes
Jul 3, 2024
| @@ -26,6 +26,7 @@ function onClickHandler(pre: HTMLElement) { | |||
| textarea.style.left = '-9999px'; | |||
| document.body.appendChild(textarea); | |||
| textarea.select(); | |||
| textarea.focus(); | |||
There was a problem hiding this comment.
Would it make more sense to focus first and then select? Just purely from the perspective of what happens when a user selects text in a textarea.
There was a problem hiding this comment.
@michalkleiner No preference over it as it needs focus just before document.execCommand('copy'); is executed for it to work always, so added there and won't make any harm I believe even if change to what you are suggesting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes copy code not working for modal due to no focus in Modal, during development of matomo-org/tag-manager#814, it was noticed that clipboard remains empty as there was no focus to textarea.
Fixes: #PG-3520
Review